open/close cross ea

User avatar
jiva34
Trader
Posts: 49
Joined: Tue Nov 15, 2011 1:26 pm

open/close cross ea

Post by jiva34 »

Using Steve's shell, "mgft" from ff coded a strategy I was working on. I added via cut and paste the Allaverages indi that Steve put together for the bbstop ea and voila we now have what appears to be a fully functional robot.
Let's see what this miracle put together by many hands can do.

not sure what time frame is best.
The strategy in general is very sucessful on the day chart.
Would be good to get it up and running nicely for shorter term trades.

21 sma open,
21 sma close

21 lsma for trend

cross down enter short trade with lsma trend

cross up enter long trade with lsma trend

The atr and partial closing functions aren't programmed in yet. so use the other stop options provided in the shell.
stop = 1 ATR

close 1/3 at +1/2 ATR
move stop to Breakeven profit +5 pips

close 1/3 at +1 ATR

can trail stop for remaining 1/3.


exit stopped out or new signal in opposite direction.

ea is being modified trailing stops functions are buggy
You do not have the required permissions to view the files attached to this post.
Last edited by jiva34 on Fri Nov 18, 2011 2:31 pm, edited 2 times in total.
User avatar
jiva34
Trader
Posts: 49
Joined: Tue Nov 15, 2011 1:26 pm

Re: open/close cross ea

Post by jiva34 »

The jumping stop, trailing stop and candle stop don't seem to be functioning (Breakeven pips set true)
User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Re: open/close cross ea

Post by SteveHopwood »

There was a logic bloop that exists in all of the stop management functions that prevented them from working if HiddenPips = 0.

I guess this bloop exists in most of the stuff I have produced recently.

I suggest you make sure this works, then copy it over the top of your version in post 1 so everyone can find it easily.

:D
You do not have the required permissions to view the files attached to this post.
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
User avatar
jiva34
Trader
Posts: 49
Joined: Tue Nov 15, 2011 1:26 pm

Re: open/close cross ea

Post by jiva34 »

SteveHopwood wrote:There was a logic bloop that exists in all of the stop management functions that prevented them from working if HiddenPips = 0.

I guess this bloop exists in most of the stuff I have produced recently.

I suggest you make sure this works, then copy it over the top of your version in post 1 so everyone can find it easily.

:D
Not working quite right.

if hidden pips is set to a value a red dotted line will appear on the chart that trails the prices using trailing stop, but the trade doesn't close.

if hidden pips is 0 nothing happens...

Break even works properly hidden pips set or not.
User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Re: open/close cross ea

Post by SteveHopwood »

The function that looks for trade exit conditions needed some extra code.

See if this works.

:D
You do not have the required permissions to view the files attached to this post.
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
winsteadglenn
Trader
Posts: 101
Joined: Tue Nov 15, 2011 10:40 pm

Re: open/close cross ea

Post by winsteadglenn »

Up 8% overnight. I like it. EU/GU/AU/UC/EJ; 2% risk. fifteen min. window . Manual close. Glenn
User avatar
jiva34
Trader
Posts: 49
Joined: Tue Nov 15, 2011 1:26 pm

Re: open/close cross ea

Post by jiva34 »

SteveHopwood wrote:The function that looks for trade exit conditions needed some extra code.

See if this works.

:D
seems to be closing alright.. as long as hidden pips is given a value...

but the trailing stop lines all remain on the chart.

This is going to be a really good one..........
User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Re: open/close cross ea

Post by SteveHopwood »

The version checks for orphan tp/sl lines every 15 minutes. They might hang around for a while, but will disappear eventually.

:D
You do not have the required permissions to view the files attached to this post.
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
User avatar
gaheitman
Trader
Posts: 655
Joined: Tue Nov 15, 2011 10:55 pm
Location: Richmond, VA, US

Re: open/close cross ea

Post by gaheitman »

Is it worth putting explicit deletes in when the bot closes trades on it's own?

Code: Select all

bool CloseTrade(int ticket)
{   
   while(IsTradeContextBusy()) Sleep(100);
   bool result = OrderClose(ticket, OrderLots(), OrderClosePrice(), 1000, CLR_NONE);

   //Actions when trade send succeeds
   if (result)
   {
      ObjectDelete(SlPrefix + DoubleToStr(ticket, 0));
      ObjectDelete(TpPrefix + DoubleToStr(ticket, 0));
      return(true);
   }//if (result)
   
   //Actions when trade send fails
   if (!result)
   {
      return(false);
   }//if (!result)
   

}//End bool CloseTrade(ticket)
BTW, quick work updating the code to make sure there were lines in the first place!

George
jiva34 wrote:
SteveHopwood wrote:The function that looks for trade exit conditions needed some extra code.

See if this works.

:D
seems to be closing alright.. as long as hidden pips is given a value...

but the trailing stop lines all remain on the chart.

This is going to be a really good one..........
User avatar
jiva34
Trader
Posts: 49
Joined: Tue Nov 15, 2011 1:26 pm

Re: open/close cross ea

Post by jiva34 »

stop lines on chart are not aprobloem now.
But it looks like the stop reverse function is not always working.
screenshot shows 2 times a short did not open when a buy was stopped out on a reverse signal..
You do not have the required permissions to view the files attached to this post.
Post Reply

Return to “Automated trading systems”